Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-32770

BasicLTI should set a default tool_consumer_instance_guid using the serverName variable

    Details

    • 11 status:
      Resolved
    • Test Plan:
      Hide

      Log in as admin, go to mercury site. Add "External Tool" in site info. Go to the tool and edits its configuration. Use https://www.tsugi.org/mod/map/ | 12345 | secret - also tick "Debug Launch". So a launch and select "Show Launch Data", you should see something like this:

      {{tool_consumer_instance_guid=a338ee40.ngrok.io
      tool_consumer_instance_url=https://a338ee40.ngrok.io}}

      Before this patch is applied, using default settings these options will not be present.

      Show
      Log in as admin, go to mercury site. Add "External Tool" in site info. Go to the tool and edits its configuration. Use https://www.tsugi.org/mod/map/ | 12345 | secret - also tick "Debug Launch". So a launch and select "Show Launch Data", you should see something like this: {{tool_consumer_instance_guid=a338ee40.ngrok.io tool_consumer_instance_url= https://a338ee40.ngrok.io }} Before this patch is applied, using default settings these options will not be present.

      Description

      The IMS LTI 2.0 implementation guide lists tool_consumer_instance_guid as "Recommended".

      ServerConfigurationService.getString("basiclti.consumer_instance_guid", ServerConfigurationService.getString("serverName", null))

      This also makes sense:

      ServerConfigurationService.getString("basiclti.consumer_instance_url", ServerConfigurationService.getString("serverUrl", null)));

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                csev Charles Severance
                Reporter:
                ottenhoff Sam Ottenhoff
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code