Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-33357

For 11 - duplicate site with peer review assignments copies the settings but misses one

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 11.4
    • Fix Version/s: 11.5 [Tentative]
    • Component/s: Assignments
    • Labels:
      None
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      When duplicating a site that contains peer review assignments these get copied too.

      However all the settings get copied:

      • peer review instructions
      • anonymous evaluation
      • number of reviews
      • student allowed to be reviews

      Except one:

      • allow peer review

       

      We fixed this in: 

      assignment/assignment-impl/impl/src/java/org/sakaiproject/assignment/impl/BaseAssignmentService.java

      (see attached screenshot)

      A database script was also needed to modify that property in the items already affected by this bug.
      The following worked for us; since our teachers always input peer review assignment instructions when they make use of a peer review assignment

      UPDATE assignment_assignment
      SET xml = REPLACE(xml, 'allowpeerassessment="false"', 'allowpeerassessment="true"') WHERE xml like '%allowpeerassessment="false"%'
      and xml not like '%peerassessmentinstructions=""%';

      Otherwise, the last part

      and xml not like '%peerassessmentinstructions=""%'

      should be modified to make sure that we are making peer review assignments only the ones that actually are.

      We found another issue in the same category (although not dependant):
      https://jira.sakaiproject.org/browse/SAK-33356

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ern Earle R Nietzel
                  Reporter:
                  ralvarez Raquel Alvarez Ramirez
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: