Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-33528

JavaScript errors when columns are hidden

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 12.0, 19.0
    • Fix Version/s: 12.0, 19.0
    • Component/s: Gradebook
    • Labels:
    • 12 status:
      Resolved
    • Test Plan:
      Hide

      Issue #1 Test Plan:

      1. Login as Instructor X and navigate GradebookNG
      2. Hide all rows except for one
      3. In another browser, login as Instructor Y and navigate to the same GradebookNG
      4. Edit a row/column that has been hidden by Instructor X
      5. Back to Instructor X's browser
      6. As the tool looks for concurrent edits, there should not be a JavaScript error in the browser console
      7. Make the column/row that was edited by Instructor Y visible
      8. The edited score should be marked as having had a concurrent edit

      Issue #2 Test Plan:

      1. Have categories & weighting with items set up in the GB.
      2. Using the "View Columns" menu hide everything except for a given item, so that its category average column is hidden.
      3. Enter scores into the visible column, ensuring that the course grade updates successfully.
      4. This should not result in a JavaScript error
      5. Showing the category average column should show the updated average score
      Show
      Issue #1 Test Plan : Login as Instructor X and navigate GradebookNG Hide all rows except for one In another browser, login as Instructor Y and navigate to the same GradebookNG Edit a row/column that has been hidden by Instructor X Back to Instructor X's browser As the tool looks for concurrent edits, there should not be a JavaScript error in the browser console Make the column/row that was edited by Instructor Y visible The edited score should be marked as having had a concurrent edit Issue #2 Test Plan: Have categories & weighting with items set up in the GB. Using the "View Columns" menu hide everything except for a given item, so that its category average column is hidden. Enter scores into the visible column, ensuring that the course grade updates successfully. This should not result in a JavaScript error Showing the category average column should show the updated average score

      Description

      NYU users/test team has found two workflows that cause a JavaScript error when columns are hidden.

      The first occurs when a concurrent edit is detected for a row or column that has been hidden.  To replicate:

      1. Login as Instructor X and navigate GradebookNG
      2. Hide all rows except for one
      3. In another browser, login as Instructor Y and navigate to the same GradebookNG
      4. Edit a row/column that has been hidden by Instructor X
      5. This will result in the JavaScript error visible in the browser console:
      Uncaught TypeError: Cannot read property 'nodeName' of null 
      at Function.m.acceptData (jquery.min.js:2) 
      at Q (jquery.min.js:4) 
      at Function.data (jquery.min.js:4) 
      at Object.GbGradeTable.setHasConcurrentEdit (gradebook-gbgrade-table.js:1263) 
      at Object.<anonymous> (gradebook-gbgrade-table.js:1952) 
      at Function.each (jquery.min.js:2) 
      at showConcurrencyNotification (gradebook-gbgrade-table.js:1951) 
      at Object.handleConcurrencyCheck [as success] (gradebook-gbgrade-table.js:1968) 
      at j (jquery.min.js:2) 
      at Object.fireWith [as resolveWith] (jquery.min.js:2)

      The second issue occurs when grading a score and their assignment's category average column is hidden.  To replicate:

      1. Have categories & weighting with items set up in the GB.
      2. Using the "View Columns" menu hide everything except for a given item, so that its category average column is hidden.
      3. Enter scores into the visible column, ensuring that the course grade updates successfully.
      4. This will result in a JavaScript error visible in the browser console.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  agschmidt Andrea Schmidt
                  Reporter:
                  paytengiles Payten Giles
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code