Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-33776

Upgrade gradebook HandsonTable to a newer version

    XMLWordPrintable

    Details

    • 19 status:
      Resolved
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      Gradebook NG uses HandsonTable 0.26.1. There have been 6 releases since then and this is almost 1.5 years old (as of Dec 2017) and hundreds of commits out of date.

      However there were some concerns by Payten about performance for a newer version and it's not a drop in replacement as the "WalkontableViewport" that they were using to patch this has either been removed or changed. Remaining on an older library version has risks going forward for both browser compatibility, features and performance.

      Thankfully we haven't modified any of the HOT code.. directly.  
      
      Prior to contributing the new table changes we did look at upgrading HOT, however it's performance on large data sets was far worse and we didn't have the capacity to restart our performance profiling and development/QA process again.  We spent a good amount of time profiling version 0.26 and identified a few performance bottlenecks, which we were able to monkey patch without degrading any features: 
      
      https://github.com/sakaiproject/sakai/blob/master/gradebookng/tool/src/webapp/scripts/gradebook-gbgrade-table.js#L1086
      
      https://github.com/sakaiproject/sakai/blob/master/gradebookng/tool/src/webapp/scripts/gradebook-gbgrade-table.js#L1101
      
      So my only reservations in upgrading would be the possible performance degradation on large datasets (e.g. 100s assignments, 1000s students); do our current monkey patches still apply; after profiling are there any new bottlenecks; and does everything else still work 
      

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  a.fish@lancaster.ac.uk Adrian Fish
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  1 Vote for this issue
                  Watchers:
                  11 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration