Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-33834

GBNG isn't using i18n strings in certain places

    Details

    • Type: Task
    • Status: Verified
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 11.4
    • Fix Version/s: 12.1, 19.0
    • Component/s: Gradebook
    • Labels:
      None
    • 12 status:
      Resolved
    • 11 status:
      Won't Fix
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      Consider the following Wicket markup:

      <a href="javascript:void(0)" id="showAllGradeItems" role="menuitem"><span wicket:message="value:label.toolbar.gradeitemshowall">Show All</span></a>
      

      This is only sticking the i18n string (label.toolbar.gradeitemshowall) in the 'value' attribute of the span tag. The text that is actually displayed is the hardcoded value of 'Show All'. If you changed the corresponding message bundle value, the text displayed will remain as 'Show All', and only the text in the 'value' attribute will be changed accordingly.

      A more appropriate way to do this is to use a <wicket:message> element for the actual text content:

            <a href="javascript:void(0)" id="showAllGradeItems" role="menuitem" class="button">
              <span wicket:message="value:label.toolbar.gradeitemshowall">
                <wicket:message key="label.toolbar.gradeitemshowall" />
              </span>
            </a>
      

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                bjones86 Brian Jones
                Reporter:
                bjones86 Brian Jones
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code