Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-33865

PASystem impl is loaded lots of times when banner displayed

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 11.4, 12.0, 19.0
    • Fix Version/s: 11.5 [Tentative], 12.0, 19.0
    • Component/s: PA System
    • Labels:
      None
    • 12 status:
      Resolved
    • 11 status:
      Resolved
    • Test Plan:
      Hide
      • As admin add a PASystem banner
      • Login as a user, make sure the banner comes up still

      Ideally also check the number of open files that match pasystem-*

      So you have to find the process id on the system of the tomcat process then do

      lsof -p <pid> | grep pasystem-
      

      It should be unchanging everytime you refresh the page to display the banner. Prior to this patch it would load the impl multiple times.

      Show
      As admin add a PASystem banner Login as a user, make sure the banner comes up still Ideally also check the number of open files that match pasystem-* So you have to find the process id on the system of the tomcat process then do lsof -p <pid> | grep pasystem- It should be unchanging everytime you refresh the page to display the banner. Prior to this patch it would load the impl multiple times.

      Description

      As noted on the list, pasystem-impl*.jar is loaded by tomcat lots of times on a running system. Testing locally this seems to be the case when setting a banner and viewing as users. It opens this file around 4 times for each page hit, and eventually after a few seconds releases this file. This looks like it's because it opens the templates out of the impl files.

      Moving them into the api (in shared) fixes this problem. Not sure if this is the best idea.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code