Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-33913

Problem with assignment conversion job

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 12.0
    • Fix Version/s: 12.0, 19.0
    • Component/s: Assignments
    • Labels:
      None
    • 12 status:
      Resolved
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      I've found an error in Assignment Conversion Job for Sakai 12. In ASN_SUBMISSION_SUBMITTER the GRADE collumn is restricted to 32 characters.

      <?xml version="1.0" encoding="UTF-8"?>
      <submission anonymousSubmissionId="503fe20fd (anónimo)"
      assignment="...." context="...."
      datereturned="20171008173108670" datesubmitted="20171008171453577"
      feedbackcomment="...."
      feedbackcomment-html="..."
      feedbacktext-html="..."
      grade0="93eed796-8060-4500-bc04-5a74e3262d2b::6" 
      grade1="a9bc04d0-8e84-44d6-9de1-b02313095bf9::6"
      grade2="dfc0f20c-30fb-42aa-ac63-42bcbbcd7d42::6" 
      graded="true"
      gradedBy="29d2873b-e890-4d31-a2b6-e7295ca94ad9" 
      gradereleased="true"
      hideduedate="false" 
      id="5fdb6a9c-5525-4cdf-94dd-909503fe20fd"
      isUserSubmission="true" 
      lastmod="20171008173108670"
      log0="....."
      pledgeflag="false" returned="true" scaled_factor="0" scaled_grade="6"
      submitted="true"
      submittedattachment0="/content/attachment/..."
      submittedtext="..."
      submittedtext-html="..."
      submitter0="dfc0f20c-30fb-42aa-ac63-42bcbbcd7d42" 
      submitter1="a9bc04d0-8e84-44d6-9de1-b02313095bf9"
      submitter2="93eed796-8060-4500-bc04-5a74e3262d2b" 
      submitterid="3fa0d3f2-078c-42f3-8421-1a6cdeb733a1">
      <properties>
      ...
      </properties>
      </submission>
      

      The conversion is trying to add the value of attributes "grade0".."grade2" (each one has 39 chars length) inside the GRADE column, but I guess only needs to add the last section (after :: ), the real grade.

      The script throws an error like this in Oracle: 

      09-feb-2018 18:55:00.877 ERROR [QuartzScheduler_Worker-4] org.hibernate.engine.jdbc.spi.SqlExceptionHelper.logExceptions ORA-12899: el valor es demasiado grande para la columna "SAKAI_12"."ASN_SUBMISSION_SUBMITTER"."GRADE" (real: 39, máximo: 32)

      I think this line should deal with anonymous submissions:

      https://github.com/sakaiproject/sakai/blob/master/assignment/impl/src/java/org/sakaiproject/assignment/impl/conversion/AssignmentConversionServiceImpl.java#L442

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                ern Earle R Nietzel
                Reporter:
                jjmerono@um.es Juan José Meroño Sánchez
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code