Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-34099

CKEditor: Disable Summary option in Table Properties dialog

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.2, 11.3, 11.4, 11.5 [Tentative], 12.0, 12.1, 19.0
    • Fix Version/s: 19.0
    • Labels:
      None
    • Test Plan:
      Hide
      1. Access a CKEditor in any tool (e.g., Lessons > Add ContentAdd Text).
      2. Select the Table button in the CKEditor menu.
      3. In the Table Properties dialog (Note: The first two attributes are not essential to see the problem, but I include them to be sure to test with a table marked up for accessibility):
        1. Headers: Select whichever option is appropriate for the data you will place in the table.
        2. Caption: Enter some text.
        3. Summary: enter some text. Note: After fix is applied, this option should not be available.
        4. Click OK.
      4. Add data in the table.
      5. Save.
      6. You'll get an Antisamy warning saying tags were stripped (the offending tag being the table summary).
      7. Edit the item that contains the table.
      8. Right-click on the table and select Table Properties.
      9. Note that there is no summary present.
      10. Close the Table Properties window and click the Source button in the CKEditor.
      11. Confirm that your
        <table>

        tag does not include a summary attribute. 

      Show
      Access a CKEditor in any tool (e.g.,  Lessons  >  Add Content >  Add Text ). Select the  Table button in the CKEditor menu. In the  Table Properties dialog ( Note:  The first two attributes are not essential to see the problem, but I include them to be sure to test with a table marked up for accessibility): Headers:  Select whichever option is appropriate for the data you will place in the table. Caption:  Enter some text. Summary: enter some text.  Note: After fix is applied, this option should not be available. Click  OK . Add data in the table. Save . You'll get an Antisamy warning saying tags were stripped (the offending tag being the table  summary ). Edit the item that contains the table. Right-click on the table and select Table Properties . Note that there is no summary present. Close the Table Properties  window and click the  Source button in the CKEditor. Confirm that your <table> tag does not include a  summary  attribute. 

      Description

      The table summary attribute is a deprecated tag (https://www.w3schools.com/tags/att_table_summary.asp) that is not recommended by WebAIM (https://webaim.org/techniques/tables/data), but the CKEditor Table Properties dialog allows you to add one.

      If you add a Summary in this dialog, Antisamy nukes it on save.

      The option should be disabled in Table Properties.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  rainribbon Tiffany Stull
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code