Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-34476

samigo: Setting feedback date earlier than due/late submission date lets students see feedback DURING test.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: OPEN
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: 10.2, 10.3, 10.4, 10.5, 10.6, 10.7, 11.0, 11.1, 11.2, 12.0, 12.1, 12.2, 12.3, 12.4, 19.0
    • Fix Version/s: None
    • Labels:
    • Previous Issue Keys:
      SAM-3083
    • Test Plan:
      Hide

      Testing after fix:

      1. Create an assessment with several questions that have point values, where you enter Correct/Incorrect Answer Feedback in the boxes for some of the questions.
      2. Select Settings.
      3. Set the due date.
      4. Open Grading and Feedback, enable Feedback at a specific date.
      5. Confirm that the feedback date field fills with the due date.
      6. Make the feedback date earlier than the due date, try to Save Settings and Publish.
      7. Confirm that you get the following error:

        The Feedback Display Date cannot be earlier than the Due Date or the Late Submission Date for the assessment or any date/time exceptions for specific students or groups.

      8. Enable the late submissions accepted option and set the late submission date after the due date, but before the feedback date, then try to save.
      9. Confirm that you get the error and can't save.
      10. Set the feedback display date after the due/late submission dates, and enable all the feedback options.
      11. Save Settings and Publish.
      12. On the Publish confirmation screen, select the Edit Settings button.
      13. Try to set the feedback date earlier than the due/late submission date, click Save, and confirm you get the error.
      14. Set the dates correctly and Save, then publish from the publish confirmation screen.
      15. Go to Published Copies > Settings.
      16. Edit the Feedback date to set it earlier than the late submissions date.
      17. Try to save and confirm you get the appropriate error.
      18. Disable late submissions and set the feedback date earlier than the due date.
      19. Try to save and confirm you get the error.
      20. Set the feedback date the same as the due date and confirm you can save successfully.
      21. Add testing steps for date exceptions enabled for multiple groups, to make sure that you can never set a feedback date later than any latest submission date for any exceptions.
      Show
      Testing after fix: Create an assessment with several questions that have point values, where you enter Correct/Incorrect Answer Feedback in the boxes for some of the questions. Select Settings . Set the due date . Open Grading and Feedback , enable Feedback at a specific date . Confirm that the feedback date field fills with the due date. Make the feedback date earlier than the due date , try to Save Settings and Publish . Confirm that you get the following error: The Feedback Display Date cannot be earlier than the Due Date or the Late Submission Date for the assessment or any date/time exceptions for specific students or groups. Enable the late submissions accepted option and set the late submission date after the due date, but before the feedback date, then try to save. Confirm that you get the error and can't save. Set the feedback display date after the due/late submission dates, and enable all the feedback options. Save Settings and Publish. On the Publish confirmation screen, select the Edit Settings button. Try to set the feedback date earlier than the due/late submission date, click Save , and confirm you get the error. Set the dates correctly and Save , then publish from the publish confirmation screen. Go to Published Copies > Settings . Edit the Feedback date to set it earlier than the late submissions date. Try to save and confirm you get the appropriate error. Disable late submissions and set the feedback date earlier than the due date. Try to save and confirm you get the error. Set the feedback date the same as the due date and confirm you can save successfully. Add testing steps for date exceptions enabled for multiple groups, to make sure that you can never set a feedback date later than any latest submission date for any exceptions .

      Description

      Issue: Samigo's Feedback Delivery option Feedback will be displayed to the student at a specific date does not check to ensure the feedback date you enter is later than the assessment's latest acceptance date (either due date or accept late submissions date).

      As a result, if you enter a date in Feedback Delivery that is EARLIER than the latest acceptance date, and students take the test AFTER the feedback display date, Samigo kindly treats the setting as if the instructor had selected Immediate Feedback and lets the student see any selected feedback WHILE they're in the process of taking the test. The issue is most likely to present itself when an instructor has duplicated/imported an older assessment - they can easily forget to update the Feedback display date even though they must update due and/or late submission dates for students to access the test.

      Samigo should verify that the Feedback Delivery date is later than the latest acceptance date (either due date or accept late submissions date) and if not, warn and prevent publishing on selecting Save, Save Settings and Publish or Publish (from any screen/drop-down menu that has a publishing option available) like it does for a due date earlier than a release date.

      In discussion on Teaching & Learning call, folks suggested that some language should display to the instructor about using Immediate Feedback to make feedback available to students while they take the test. The linked SAK-34674 includes language to address this concern.

      Suggested fix:

      1. On selecting Feedback at a specific date, automatically populate the date field with the latest submission date ("retract date" in the code) allowed for the assessment or any exceptions that have been enabled.
      2. If instructor edits the date to be earlier than that, block save with an appropriate error message at the top of the screen which will allow the instructor to fix the error, e.g.:

        The Feedback Display Date cannot be earlier than the Due Date or the Late Submission Date for the assessment or any date/time exceptions for specific students or groups.

      NOTE:

      • This needs to be tested in BOTH Working and Published Copies (or new Sakai 19 equivalent of Draft and published).
      • If late submissions ARE accepted, but NO late accept date is entered (i.e. late accepted for eternity), it should key the "latest submission date" needed for the purpose of setting a feedback date off the assessment's due date.

      To reproduce:

      1. Create an assessment with several questions, where you enter Correct/Incorrect Answer Feedback in the boxes for some of the questions.
      2. Select Settings.
      3. Under Availability and Submissions, enter a due date in the future.
      4. Click on Grading and Feedback. Select Feedback will be displayed to the student at a specific date and enter some date in the past. Select Release Questions and the following and check ALL available feedback type boxes.
      5. Log in as a student and start taking the test.
      6. Click on the handy Feedback button to see the answers and Question-Level Feedback to the question you're viewing.
      7. Select some correct answers and some incorrect answers, then click on the Table of Contents; you'll see your question and part scores, because those have also been made available in the feedback.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  maintenanceteam Core Team
                  Reporter:
                  rainribbon Tiffany Stull
                  Votes:
                  8 Vote for this issue
                  Watchers:
                  14 Start watching this issue

                    Dates

                    Created:
                    Updated:

                      Git Integration