XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Duplicate
    • Affects Version/s: 11.0
    • Fix Version/s: None
    • Labels:
    • Test Plan:
      Hide

      Here's how I might try to test this:

      You need samigo.autoSubmit.enabled=true and the quartz job setup as documented in
      https://raw.githubusercontent.com/jonespm/sakai/master/samigo/docs/auto_submit/README.autoSubmit.txt

      • Then create an assessment giving a student extra time as described in the feature on SAM-1408 and a due date that's already passed.
      • Wait for the due date to pass (unless already passed) and try to run the auto submit job

      Ideally the job won't submit the this students assessment that was extended but I believe it will since all checks will have passed.

      Show
      Here's how I might try to test this: You need samigo.autoSubmit.enabled=true and the quartz job setup as documented in https://raw.githubusercontent.com/jonespm/sakai/master/samigo/docs/auto_submit/README.autoSubmit.txt Then create an assessment giving a student extra time as described in the feature on SAM-1408 and a due date that's already passed. Wait for the due date to pass (unless already passed) and try to run the auto submit job Ideally the job won't submit the this students assessment that was extended but I believe it will since all checks will have passed.

      Description

      Just looking at the code when the autosubmit job runs in quartz it will run autoSubmitAssessments in AssessmentGradingFacadeQueries.java

      This method was not modified for SAM-1408 for the extended due dates metadata. This will very likely result in any students having their due dates extended still having their submissions auto submitted when this job runs.

      It seems like it's going to be semi-complicated to fix this unless a method like assessment.getDueDate is fixed to also return the extended due date or there's a new api method that returns the real effective due date for a student. (Which I don't see existing)

      I haven't tested this yet so please close if it's a non issue but I don't want to forget about it.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  samigoteam SAMIGO TEAM (Inactive)
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration