Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-35026 Investigate code efficiency in delivery
  3. SAK-35130

Remove helper methods that convert Sets to HashMaps

    XMLWordPrintable

    Details

      Description

      While investigating issues with excessive Samigo queries, I could not get the queries against the PublishedItemFeedback or PublishedItemMetaData tables to decrease even with caches, batch fetching, etc.

      After profiling with YourKit, I found that these helper methods that converted the Sets to Maps for easy retrieval were causing the database to be hit thousands of times.

      Patch attached to remove these helper functions and replace with simple iterations over the Set.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ottenhoff Sam Ottenhoff
                  Reporter:
                  ottenhoff Sam Ottenhoff
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code