XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Verified
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 12.0
    • Fix Version/s: 12.0
    • Labels:
    • Test Plan:
      Hide

      After each test below, log in as a student who has the "exception" and test for them. And test for a student who has no "exception". If necessary, make copies of the test (for example if you can't edit the test after it has been published, or if it just makes it easier to test the different variations). 

      The editing came about when you left the date blank initially and tried to update it after

      • Add a quiz
      • Add  an exception for a student, leaving the dates blank
      • Save the exception
      • Click edit next to the exception
      • Update the row, adding a due date and click update
      • There shouldn't be any error updating.

      The deletion bug came up if two items had the same user name and either didn't have a published (or unpublished) assessment id so

      • Add 2 extended time entires with the same user name
      • Attempt to delete one of them, you should be able to delete all of them in both a published and unpublished assessment.
      Show
      After each test below, log in as a student who has the "exception" and test for them. And test for a student who has no "exception". If necessary, make copies of the test (for example if you can't edit the test after it has been published, or if it just makes it easier to test the different variations).  The editing came about when you left the date blank initially and tried to update it after Add a quiz Add  an exception for a student, leaving the dates blank Save the exception Click edit next to the exception Update the row, adding a due date and click update There shouldn't be any error updating. The deletion bug came up if two items had the same user name and either didn't have a published (or unpublished) assessment id so Add 2 extended time entires with the same user name Attempt to delete one of them, you should be able to delete all of them in both a published and unpublished assessment.

      Description

      When creating the initial extended time exception I could leave the dates blank. This seems like the expected case and just fill in a time.

      However when editing it would either fill in a default time or return an NPE stack trace.

      caused by: java.lang.NullPointerException
          at org.sakaiproject.tool.assessment.ui.bean.author.AssessmentSettingsBean.saveEditedExtendedTime(AssessmentSettingsBean.java:1776)
      

      This should be investigated and fixed.

      Also seems to be some error with deleting an entry with dates blank

      caused by: java.lang.NullPointerException
          at org.sakaiproject.tool.assessment.data.dao.assessment.ExtendedTime.equals(ExtendedTime.java:83)
          at java.util.ArrayList.remove(ArrayList.java:528)
          at org.sakaiproject.tool.assessment.ui.bean.author.AssessmentSettingsBean.deleteExtendedTime(AssessmentSettingsBean.java:1761)
      

      See test plan with info specific to this.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code