Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-35101 Refactor extended time database model to be more efficient
  3. SAK-35152

When editing an extended time entry, old row should be deactivated/deleted

    XMLWordPrintable

    Details

    • Test Plan:
      Hide

      I'd make sure all these cases work to verify this. Test on published and unpublished

      • First add an extended time entry (fill in at least a user or group)
      • Expected: It should add a row to the table
      • Then click Edit
      • The row should be removed and the buttons should change from add to update
      • Change some values and click update
      • The values should be updated on the row and the edited item should now change over to add
      • Edit an item again, and change the user id
      • Should go back into editing
      • Click cancel
      • The item should go back as it was to the table with the previous id
      • Click edit and change the user
      • Then click save, and try to repeat this. It should all work, and the previous user should have also saved.
      Show
      I'd make sure all these cases work to verify this. Test on published and unpublished First add an extended time entry (fill in at least a user or group) Expected: It should add a row to the table Then click Edit The row should be removed and the buttons should change from add to update Change some values and click update The values should be updated on the row and the edited item should now change over to add Edit an item again, and change the user id Should go back into editing Click cancel The item should go back as it was to the table with the previous id Click edit and change the user Then click save, and try to repeat this. It should all work, and the previous user should have also saved.

      Description

      When you add an extended time entry and then edit, it's not entirely obvious what row you're editing since it doesn't change. Also if you click "delete" on this row, and later update the entry you were working on, the system throws a stack trace.

      It seems like the easiest situation would be to when placing the row into an edit state, delete the entry. Maybe call it:

      Still "Edit" but instead of Update "Re-add updated entry" ? This seems easier than disabling out that row.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code