Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-35269

Runtime Exceptions still break the autosubmit job

    XMLWordPrintable

    Details

    • 11 status:
      Resolved
    • 10 status:
      Resolved
    • Previous Issue Keys:
      SAM-2701

      Description

      We have been reported that autosubmit feature was not working for Samigo tests in our 10.5 production server.

      Looking in the logs it seems that one corrupted assessment, not visible by teachers, is giving the next exception:

      (1) 2016-01-27 01:03:38,771 ERROR QuartzScheduler_Worker-3 org.sakaiproject.tool.assessment.services.ItemService - java.lang.IndexOutOfBoundsException: Index: 0, Size: 0

      And in the end Hibernate rolls back the full transaction, throwing the next exception in logs:

      (2) org.springframework.transaction.UnexpectedRollbackException: Transaction rolled back because it has been marked as rollback-only
      at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:718)
      at org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:475)
      at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:270)
      at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:94)
      at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
      at com.sun.proxy.$Proxy95.autoSubmitAssessments(Unknown Source)
      at org.sakaiproject.tool.assessment.services.GradingService.autoSubmitAssessments(GradingService.java:2979)
      at org.sakaiproject.tool.assessment.services.AutoSubmitAssessmentsJob.execute(AutoSubmitAssessmentsJob.java:77)
      at org.sakaiproject.component.app.scheduler.jobs.SpringJobBeanWrapper.execute(SpringJobBeanWrapper.java:70)
      at org.quartz.core.JobRunShell.run(JobRunShell.java:223)
      at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549)

      This issue is the same that was supposedly fixed in SAM-2074. We suspect that the fix in that ticket is not really working. The fix consisted in capturing the exception and returning a -1 value, but it seems that simply the happening of the exception breaks the Hibernate transaction.

      Unfortunately we have solved this issue deleting the corrupt assessment from database, so we can not test if another solution works fine. We can only assure that doesn't break anything. So I wonder if maybe we should close this as "Not reproducible".

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  samigoteam SAMIGO TEAM (Inactive)
                  Reporter:
                  daniel.merino Daniel Merino Echeverría
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration