Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-36102

Issues with deadlock retry in AssesmentGradingQueries

    Details

    • Previous Issue Keys:
      SAM-2080

      Description

      The saveOrUpdateAll method in assesment grading queries:

      public void saveOrUpdateAll(Collection c) {
      int retryCount = persistenceHelper.getRetryCount().intValue();
      while (retryCount > 0){
      try

      { getHibernateTemplate().saveOrUpdateAll(c); retryCount = 0; }

      catch (Exception e)

      { log.warn("problem inserting assessmentGrading: "+e.getMessage()); retryCount = persistenceHelper.retryDeadlock(e, retryCount); }

      }
      }

      There are some problems with this code:

      1) All Exceptions are retried whether they are locks or not.
      2) if the query fails this is not reported to the calling method at all

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  samigoteam SAMIGO TEAM (Inactive)
                  Reporter:
                  dhorwitz David Horwitz
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration