Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-36410

NPE in grading

    XMLWordPrintable

    Details

    • 2.9 Status:
      Merge
    • Previous Issue Keys:
      SAM-1724

      Description

      NPE seen in production on 2.8x system:

      caused by: java.lang.NullPointerException
      at org.sakaiproject.tool.assessment.services.GradingService.storeGrades(GradingService.java:808)
      at org.sakaiproject.tool.assessment.services.GradingService.storeGrades(GradingService.java:707)
      at org.sakaiproject.tool.assessment.ui.listener.delivery.SubmitToGradingActionListener.persistAssessmentGrading(SubmitToGradingActionListener.java:364)
      at org.sakaiproject.tool.assessment.ui.listener.delivery.SubmitToGradingActionListener.submitToGradingService(SubmitToGradingActionListener.java:256)
      at org.sakaiproject.tool.assessment.ui.listener.delivery.SubmitToGradingActionListener.processAction(SubmitToGradingActionListener.java:113)
      at org.sakaiproject.tool.assessment.ui.bean.delivery.DeliveryBean.confirmSubmit(DeliveryBean.java:1407)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:597)
      at com.sun.faces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:126)
      at com.sun.faces.application.ActionListenerImpl.processAction(ActionListenerImpl.java:72)
      at javax.faces.component.UICommand.broadcast(UICommand.java:312)
      at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:267)
      at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:381)
      at com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:75)
      at com.sun.faces.lifecycle.LifecycleImpl.phase(LifecycleImpl.java:200)

      The line matches:

      ItemDataIfc item = (ItemDataIfc) publishedItemHash.get(itemId);
      Long itemType2 = item.getTypeId();

      an earlier call checks for a null entry. Fixing this to match

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  dhorwitz David Horwitz
                  Reporter:
                  dhorwitz David Horwitz
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration