Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-36511

Request to change API name in AssessmentGradingFacadeQueries.java

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0
    • Labels:
      None
    • Previous Issue Keys:
      SAM-883

      Description

      Reported by Qu from Texas State University:

      During my implementation, I found one thing and I doubt if that was a mistake:

      In AssessmentGradingFacadeQueries.java

      public List getItemGradingIds(final Long assessmentGradingId){ final HibernateCallback hcb = new HibernateCallback(){ public Object doInHibernate(Session session) throws HibernateException, SQLException

      { Query q = session.createQuery("select i.publishedItemId from "+ " ItemGradingData i where i.assessmentGradingId=?"); q.setLong(0, assessmentGradingId.longValue()); return q.list(); }; }; return getHibernateTemplate().executeFind(hcb); }


      Should it be :


      public List getPublishedItemIds(final Long assessmentGradingId){ final HibernateCallback hcb = new HibernateCallback(){ public Object doInHibernate(Session session) throws HibernateException, SQLException { Query q = session.createQuery("select i.publishedItemId from "+ " ItemGradingData i where i.assessmentGradingId=?"); q.setLong(0, assessmentGradingId.longValue()); return q.list(); }

      ; }; return getHibernateTemplate().executeFind(hcb); }

      Since it is getting PublishedItemIds, not actual ItemGradingId.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                jthapa Jasmine Thapa (Inactive)
                Reporter:
                ktsao Karen Tsao
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code