Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-36514

Use StringUtils.isNotBlank when Saving Display score option in published assessments

    XMLWordPrintable

    Details

    • 11 status:
      Resolved
    • Previous Issue Keys:
      SAM-2918

      Description

      During some test we had problems saving published assessments settings from SAKAI 10.x in SAKAI 11. This new property "Display Score" did not exists in SAKAI 10 so i might be a good idea to use StringUtils.isNotBlank (just like it´s done when you save the settings for a unpublished assessment)

      Saving settings in an unpublished assessment

          if (StringUtils.isNotBlank(assessmentSettings.getAssessmentFormat())) {
            control.setAssessmentFormat(new Integer(assessmentSettings.getAssessmentFormat()));
          }
      

      Saving settings in an published assessment

      if (assessmentSettings.getDisplayScoreDuringAssessments() != null) {
      	control.setDisplayScoreDuringAssessments(new Integer(assessmentSettings.getDisplayScoreDuringAssessments()));
      		}
      

      IMO both should use StringUtils.isNotBlank

      This new property was added in SAM-1117

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  alexgj Alejandro González Jiménez
                  Reporter:
                  alexgj Alejandro González Jiménez
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration