Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-36908

Total Scores: comment field disabled for student submissions, submit date column blank

    XMLWordPrintable

    Details

    • 12 status:
      Resolved
    • Previous Issue Keys:
      SAM-3243
    • Test Plan:
      Hide

      1) create and publish a quiz that's set to push scores/comments to the gradebook
      2) submit to the quiz as student/access member
      3) as instructor/maintainer go to Total Scores (scores) for the assessment
      4) find the row in the table for the student/access member you took the quiz with
      5) notice there is a submission, with a grade, and make a comment on the grade (as instructor). 
      6) verify the grade/comment is pushed to the Gradebook

      Show
      1) create and publish a quiz that's set to push scores/comments to the gradebook 2) submit to the quiz as student/access member 3) as instructor/maintainer go to Total Scores (scores) for the assessment 4) find the row in the table for the student/access member you took the quiz with 5) notice there is a submission, with a grade, and make a comment on the grade (as instructor).  6) verify the grade/comment is pushed to the Gradebook

      Description

      Steps to reproduce:

      1) create and publish a quiz that's set to push scores/comments to the gradebook
      2) submit to the quiz as student/access member
      3) as instructor/maintainer go to Total Scores (scores) for the assessment
      4) find the row in the table for the student/access member you took the quiz with
      5) notice there is a submission, with a grade, but the comment box is disabled and has the placeholder text "Requires student submission" and the "Submitted Date" column is blank (see attached screenshot)

      You'll notice the following warning in the logs:

      WARN [http-nio-8450-exec-20] org.sakaiproject.tool.assessment.ui.listener.evaluation.TotalScoreListener.prepareAgentResult Cannot invoke org.sakaiproject.tool.assessment.ui.bean.evaluation.AgentResults.setIsAutoSubmitted on bean class 'class org.sakaiproject.tool.assessment.ui.bean.evaluation.AgentResults' - null - had objects of type "<null>" but expected signature "boolean"
      

      This warning is being generated from TotalScoresListener.prepareAgentResult() @ lines 598-603:

            try{
              BeanUtils.copyProperties(results, gdata);
            }
            catch(Exception e){
              log.warn(e.getMessage());
            }
      

      BeanUtils is throwing an IllegalArgumentException because AgentResults.isAutoSubmitted is a primative boolean, white AssessmentGradingData.isAutoSubmitted is a Boolean object. So BeanUtils.copyProperties() blows up and fails to copy over all of the properties of the source object (AssessmentGradingData).

      This results in the AgentResult objects not having values populated for attemptedDate and submittedDate. The presence of these values is what determines if the Total Scores' column has a value for the "Submit Date" column, and whether or not the user gets an editable/enabled text field for the comments.

      Changing AgentResult.isAutoSubmitted from boolean to Boolean resolves this issue. I'm not aware of how/when this regressed, as it's not an issue in 11.x or prior versions.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                bjones86 Brian Jones
                Reporter:
                bjones86 Brian Jones
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code