Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-36927

Aborted "Remove Attachment" Leads to 404

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.9.0, 2.9.1, 2.9.2, 2.9.3
    • Fix Version/s: None
    • Labels:
      None
    • Previous Issue Keys:
      SAM-2251

      Description

      When a user attempts to remove a file from an assessment question, but later (before saving the question) rethinks the matter and decides not to (reloads the page, simply closes the browser), Samigo becomes inconsistent with the Content service, continuing to think that it has an attachment which was previously deleted. Ultimately this was discovered locally when the students attempted to view the attachment.

      To replicate the issue:

      1.) Create a new assessment with a single question of any type allow attachments.
      2.) Attach a file to the question; save the question.
      3.) Return to edit the question.
      4.) Click "Add / Remove Attachments".
      5.) Remove the attached file.
      6.) Click "Continue" to return to the Edit Question page.
      7.) Click the "Questions: [[Asssessment Name]]" link at the top.
      8.) Click to view the attachment for the question.
      9.) Receive 404.

      To be fair, if the user understood what we were thinking and always clicked "Cancel", this wouldn't be a problem, but we can say experientially that they don't .

      I would propose that a few different ways of handling this could take place:
      1.) Not committing the content service changes until after the user clicks Save.
      2.) Remove the attachment from the question item (and save only that change) immediately on return to the question editing screen itself.
      3.) Check that the content item still exists when entering the question listing, updating questions as necessary to remove defunct attachments. Probably throw a WARN message in case there are filesystem issues which admin needs to address.

      I've not done any meaningful assessment of the relevant code yet; just wanted to get this out there while it's fresh in the mind.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                • Assignee:
                  samigoteam SAMIGO TEAM (Inactive)
                  Reporter:
                  seanrbaker Sean Baker
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Integration