Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-36956

Samigo will consider a Test 'active' if the due date is passed, it doesn't accept late submissions, but there is at least one user who has been given the ability to take a retake

    Details

    • 10 status:
      Resolved
    • Previous Issue Keys:
      SAM-2646

      Description

      Samigo has a logic flaw that will make a test appear as 'Active' in the authorIndex UI even if the due date is passed and late submissions are not accepted.

      Steps to reproduce:

      1. create a quiz with the following settings:
        1. a start and end date
        2. does not allow late submissions
      2. as any student user, use up all of your available submissions
      3. as the maintainer, go to the test's 'Scores' UI, and click the 'Submission Status' link at the top
      4. find the student you from the previous step that has used all of their submission attempts
      5. click the link to 'Allow Retake?'
      6. DON'T use the retake for the given student
      7. allow the due date to pass, or change the due date so that it has already passed
      8. view the authorIndex page, and notice that the 'Status' is still marked as 'Active'

      The user with the available retake will not be able to use this retake, as the due date has passed and the test does not accept late submissions. The problem is a small piece of code in the AuthorActionListerner.isStillAvailable() method:

      if (actualNumberRetake < numberRetake) {
      			  isStillAvailable = true;
      }

      This code block does not take into account the quiz's setting for allowing submissions passed the due date, and thus will always return true (the test is active) if the following conditions are met:

      1. the test is passed the due date
      2. any user in the group/site still has available retakes
      3. late submissions are not accepted

      To fix this, the conditional just needs a very small tweak:

      if (actualNumberRetake < numberRetake && acceptLateSubmission) {
      			  isStillAvailable = true;
      }

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                bjones86 Brian Jones
                Reporter:
                bjones86 Brian Jones
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code