Type: (Deprecated) Contributed Patch
Affects Version/s: 11.0
Fix Version/s: 11.1
Component/s: Tests & Quizzes (Samigo)
Previous Issue Keys:SAM-2894
Currently within Samigo there has recently (
SAM-2374) been created a second authorIndex.jsp page titled authorIndex_noHeader.jsp.
This was done because JSP complains (and breaks) when you include a page which has <f:view> within another <f:view>, specifically within mainIndex.jsp.
This is a relatively new change which has resulted in two files for the same page which must both be maintained. This results in twice the work to add new features / fix bugs and increases the odds of discrepancies. Currently a number of discrepancies exist:
- authorIndex.jsp:L153 | authorIndex_noHeader.jsp:L49
- authorIndex.jsp:L194 | authorIndex_noHeader,jsp:L194
- authorIndex.jsp:L313 | authorIndex.jsp:L309
This is a terrible practice and there is no reason to make samigo worse.
This change takes authorIndex.jsp renames it to authorIndex_content.jsp, creates authorIndex_container.jsp (modeled after mainIndex.jsp) which just includes authorIndex_content.jsp, and removes authorIndex_noHeader.jsp. All outcomes which pointed to authorIndex.jsp now point to authorIndex_container.jsp. The mainIndex.jsp page now includes the authorIndex_content.jsp.