Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-37205

Improve Samigo Author Page

    XMLWordPrintable

    Details

    • Type: (Deprecated) Contributed Patch
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.0
    • Fix Version/s: 11.1
    • Labels:
    • 11 status:
      Resolved
    • Previous Issue Keys:
      SAM-2894
    • Test Plan:
      Hide

      Make sure saving an Assessment settings works, Publishing an assessment works, removing an assessment (both published and unpublished) works, also ensure that going to the T&Q assessment landing page works.

      Show
      Make sure saving an Assessment settings works, Publishing an assessment works, removing an assessment (both published and unpublished) works, also ensure that going to the T&Q assessment landing page works.

      Description

      Currently within Samigo there has recently (SAM-2374) been created a second authorIndex.jsp page titled authorIndex_noHeader.jsp.

      This was done because JSP complains (and breaks) when you include a page which has <f:view> within another <f:view>, specifically within mainIndex.jsp.

      This is a relatively new change which has resulted in two files for the same page which must both be maintained. This results in twice the work to add new features / fix bugs and increases the odds of discrepancies. Currently a number of discrepancies exist:

      This is a terrible practice and there is no reason to make samigo worse.

      This change takes authorIndex.jsp renames it to authorIndex_content.jsp, creates authorIndex_container.jsp (modeled after mainIndex.jsp) which just includes authorIndex_content.jsp, and removes authorIndex_noHeader.jsp. All outcomes which pointed to authorIndex.jsp now point to authorIndex_container.jsp. The mainIndex.jsp page now includes the authorIndex_content.jsp.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  Sristi Sristi Shrestha
                  Reporter:
                  lcanessa Leonardo Canessa
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code