Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-37249

A few small issues with Samigo email notifications

    Details

    • Type: (Deprecated) Contributed Patch
    • Status: Verified
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 11.0
    • Fix Version/s: 11.0, 12.0
    • Labels:
      None
    • 11 status:
      Resolved
    • Previous Issue Keys:
      SAM-2794
    • Test Plan:
      Hide

      1) Ensure the tool doesn't blow up when setting up a new assessment to use email notifications. Also ensure the tool doesn't blow up when editing a assessment created prior to adding this feature, and an assessment that is already currently using the setting (a published assessment)

      2) Ensure the emails contain references to "ui.service" from sakai.properties, rather than the hard-coded instance name "Isidore"

      3) Check the email templates in Administration Workspace. Ensure the three sam.* email templates are saved as the 'default' locale, rather than en_US

      Show
      1) Ensure the tool doesn't blow up when setting up a new assessment to use email notifications. Also ensure the tool doesn't blow up when editing a assessment created prior to adding this feature, and an assessment that is already currently using the setting (a published assessment) 2) Ensure the emails contain references to "ui.service" from sakai.properties, rather than the hard-coded instance name "Isidore" 3) Check the email templates in Administration Workspace. Ensure the three sam.* email templates are saved as the 'default' locale, rather than en_US

      Description

      The linked PR will address the following minor issues:

      • Catch possible NPE/NFE when accessing assessment setting for instructor notification
      • Remove hard-coded Dayton instance name in favour of "ui.service" from sakai.properties
      • Remove hard-coded en_US locale from email template XML so the templates are loaded as 'default' locale

      Also did some minor clean-up in the files while I was editing them.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  bjones86 Brian Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code