Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-37412

When importing from cartridge HTML should be inline rather than linked

    Details

    • Type: Feature Request
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.4
    • Fix Version/s: 11.0
    • Component/s: Lessons
    • Labels:
      None
    • Previous Issue Keys:
      LSNBLDR-455
    • Test Plan:
      Hide

      Several cases need to be tested:
      inline HTML, need block with 0, 1, and 2 URLs pointing into resources
      inline objects of other types:
      oembed, youtube, image, MP4 hosted on Sakai, embed code, web site (will be displayed in iframe)

      They need to be imported on sakai (with the patch) and some other system. In Sakai the types that appear online in the page should come back that way (though without attributes such as height and width). In the other system they come back as links.

      For completeness it might be worth importing into Sakai without the patch. It should work just like non-Sakai systems.

      Show
      Several cases need to be tested: inline HTML, need block with 0, 1, and 2 URLs pointing into resources inline objects of other types: oembed, youtube, image, MP4 hosted on Sakai, embed code, web site (will be displayed in iframe) They need to be imported on sakai (with the patch) and some other system. In Sakai the types that appear online in the page should come back that way (though without attributes such as height and width). In the other system they come back as links. For completeness it might be worth importing into Sakai without the patch. It should work just like non-Sakai systems.

      Description

      If you import a common cartridge either from a publisher or one that has been previously exported from Lessons, it doesn't come up exactly the same because any content that was previously created as inline "Add Text" when it's imported is just linked as HTML documents so it's not the same. I think that any content that is HTML should just be presented again as inline.

      Maybe this could be a configuration option to preserve the existing behavior, or an option during import, but I think most people will want it to be inline. I have a patch for this that I'll submit a pull request for. It moves around the inline filter that was used so that filter is used on this incoming text, but otherwise doesn't change too much.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  hedrick Charles Hedrick
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code