Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-37623

subnav feature from SAK-32760 not properly implemented

    Details

    • 12 status:
      Resolved
    • Previous Issue Keys:
      LSNBLDR-952
    • Test Plan:
      Hide

      Set up a site with at least one subpage. Make some item before it that is required, and don't do it.

      Now change various parameters and make sure they are reflected in the left margin for a student:

      • Hide the page until date. If the page is not required it should vanish.
      • If the page is required it should show with the left margin saying when it is released
      • Release the page to a group that the student isn't in. The page should vanish
      • Set prerequisites for the page. The left margin should show that.
      Show
      Set up a site with at least one subpage. Make some item before it that is required, and don't do it. Now change various parameters and make sure they are reflected in the left margin for a student: Hide the page until date. If the page is not required it should vanish. If the page is required it should show with the left margin saying when it is released Release the page to a group that the student isn't in. The page should vanish Set prerequisites for the page. The left margin should show that.

      Description

      The subnav feature from SAK-32760 has issues. It assumes that something has a prereq if it isn't accessible. But in fact items can be inaccessible if:

      • user won't see them at all because of groups
      • there are unmet prerequisites
      • underlying item doesn't exist or is hidden

      The data returned by the ajax call thus needs to show all of these possible variations, and the Javascript needs to display it properly.

      Also, simplePageToolDao.findItemsOnPage isn't properly implemented. It can miss pages that are both top level and occur somewhere else in the tree. The actual list of top-level pages comes by lookup on top level page items and then finding the page.

       

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  maintenanceteam Core Team
                  Reporter:
                  hedrick Charles Hedrick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code