Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-37680

Stacktrace in lessons with seeall but not upd on deleted items

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: OPEN
    • Priority: Critical
    • Resolution: Unresolved
    • Affects Version/s: 11.5 [Tentative], 12.0, 19.0
    • Fix Version/s: None
    • Component/s: Lessons
    • Labels:
    • Previous Issue Keys:
      LSNBLDR-873
    • Test Plan:
      Hide

      Note: This test plan could use some expansion on some of the steps.

      To get this to work you'll have to add or customize a role in the class with the permisisons

      lessonbuider.seeall
      but not lessonbuiderl.upd.

      On a course site on nightly, you could take the teaching assistant role or even a Student is fine. Go to lessons -> More Tools -> Permissions and add the permission "See items regardless of release controls" but don't have the "Update all pages or items" checked.

      Then as an instructor create something linked like an assessment in lessons.
      Delete the assessment

      Try to login as the user with the role that can see items. Before fixing this you should get a stack trace. After the fix there should be no stack trace.

      Show
      Note : This test plan could use some expansion on some of the steps. To get this to work you'll have to add or customize a role in the class with the permisisons lessonbuider.seeall but not lessonbuiderl.upd. On a course site on nightly, you could take the teaching assistant role or even a Student is fine. Go to lessons -> More Tools -> Permissions and add the permission "See items regardless of release controls" but don't have the "Update all pages or items" checked. Then as an instructor create something linked like an assessment in lessons. Delete the assessment Try to login as the user with the role that can see items. Before fixing this you should get a stack trace. After the fix there should be no stack trace.

      Description

      In Lessons if user has lessonbuilder.seeall but not lessonbuilder.upd on their role and they access a page with a linked assessment that has been deleted, they'll get a stack trace.

      It looks like the error is in the

      if (canSeeAll) where the entity is not rechecked for null. in any of these cases here.

      Fatal internal error handling request: 
Target exception of class java.lang.NullPointerException
Successive lines until stack trace show causes progressing to exception site:
java.lang.NullPointerException
	at org.sakaiproject.lessonbuildertool.tool.producers.ShowPageProducer.fillComponents(ShowPageProducer.java:1606)
	at uk.org.ponder.rsf.view.support.ViewCollector.fillComponents(ViewCollector.java:56)
	at uk.org.ponder.rsf.view.support.LayoutCollector.fillComponents(LayoutCollector.java:68)
	at sun.reflect.GeneratedMethodAccessor2955.invoke(Unknown Source)

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

              relates to

              Feature Request - Functionality that you would like to see in Sakai. SAK-37473 add permission for use by reviewer

              • Major - Major loss of function or need for functionality in production in the near future.
              • RESOLVED

                Activity

                  People

                  • Assignee:
                    maintenanceteam Core Team
                    Reporter:
                    jonespm Matthew Jones
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:

                      Git Integration