Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-37753

Required assignments linked to lessons release requirement before submission

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 10.8 [Tentative], 11.5 [Tentative], 12.0, 19.4
    • Fix Version/s: 19.4, 20.0, 21.0 [Tentative]
    • Component/s: Lessons
    • Labels:
      None
    • 20 status:
      Resolved
    • 19 status:
      Verified
    • Previous Issue Keys:
      LSNBLDR-874
    • Test Plan:
      Hide

      In a site with at least one student add Lessons and Assignment

       

      Create an assignment, no special case

      Create a lesson

      Link to the assignment 

      Edit the Lesson item and mark it that the student is required to submit

      Confirm a black Asterisk

       

      Login as a student confirm that the student sees the assignment is required.

      Login as instructor, go to assignment and click "Grade" or "View Submissions" on that assignment

      Log back in as a student. The assignment shouldn't be released, but it has a green checkbox by just the instructor viewing the submissions.

       

      Show
      In a site with at least one student add Lessons and Assignment   Create an assignment, no special case Create a lesson Link to the assignment  Edit the Lesson item and mark it that the student is required to submit Confirm a black Asterisk   Login as a student confirm that the student sees the assignment is required. Login as instructor, go to assignment and click "Grade" or "View Submissions" on that assignment Log back in as a student. The assignment shouldn't be released, but it has a green checkbox by just the instructor viewing the submissions.  

      Description

      In what I believe is possibly a regression from SAK-29314, if you have a linked assignment marked as "Submission Required" in lessons, the assignment is released as soon as the instructor does a view submission or grades.

      I think this is because the AssignmentEntity in Lessons doesn't check this new method there isUserSubmission and instead just checks getSubmitted. I believe it should also check this new method.

      This currently can't be tested in 12 or master because when I link an assignment it says Deleted next to it (which is some new/separate error)

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                a.fish@lancaster.ac.uk Adrian Fish
                Reporter:
                jonespm Matthew Jones
                Votes:
                4 Vote for this issue
                Watchers:
                10 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration