Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38059

bad logic in visibility

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 12.0
    • Fix Version/s: 12.1, 19.0
    • Component/s: Lessons
    • Labels:
      None
    • 12 status:
      Resolved
    • 11 status:
      Please Merge
    • Previous Issue Keys:
      LSNBLDR-948
    • Test Plan:
      Hide

      Changes are for links to page, assignment, test, forum.

      Before: if they are not published or not released, they don't show.

      After: it they are not published or not released, and they are required, they show, but are grayed out with a label that they are not yet released.

      So to test you'll want a page, an assignment, a test, and a forum. Set them not released. For page, it can be either hidden or not yet to release date. For the others, it's not released in the tool, which may be not published (test) or not released.

      If the items aren't required, they aren't shown.

      Set them to required. They should show grayed out.

      Later items marked has prerequisites show not be available.

      Now release the items. They should show normally whether required or not. If required, dependent items should't be avaiable until they're done.

       

      Show
      Changes are for links to page, assignment, test, forum. Before: if they are not published or not released, they don't show. After: it they are not published or not released, and they are required, they show, but are grayed out with a label that they are not yet released. So to test you'll want a page, an assignment, a test, and a forum. Set them not released. For page, it can be either hidden or not yet to release date. For the others, it's not released in the tool, which may be not published (test) or not released. If the items aren't required, they aren't shown. Set them to required. They should show grayed out. Later items marked has prerequisites show not be available. Now release the items. They should show normally whether required or not. If required, dependent items should't be avaiable until they're done.  

      Description

      I think I made a fairly serious mistake in deciding what items to show. A number of people ask me not to show tests that aren't published, etc. That makes sense most of the time. But if they aren't required, I think I need to show them all the time. The problem is that if a test isn't published, but it's required, letter items that depend upon it shouldn't be available yet. They shouldn't open until the test is published and the student passes it. If items are invisible until they're released, later items will be available that shoudn't be.

       

      So I propose to change isItemVisible to that any item that's required is visible, as long as the student is in the right groups to see it. This is going to be a bit complex for Samigo, since it's not clear I can find groups for an unpublished test. I'm probably going to have to use Lessons' own concept of groups in that case. (I would recommend that people publish the test and use release date to control when it's available.)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  maintenanceteam Core Team
                  Reporter:
                  hedrick Charles Hedrick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code