Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38093

Lessons event ref for event type 'lessonbuilder.read' is ambiguous

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.7
    • Fix Version/s: 11.4, 12.0
    • Component/s: Lessons
    • Labels:
    • 11 status:
      Resolved
    • Previous Issue Keys:
      LSNBLDR-736

      Description

      All lessons event refs are in the following format:

      "/lessonbuilder/[page|item|comment]/<ID>"

      The middle chunk of the ref determines what type of object the event is referring to; either a SimplePage, SimplePageItem, or SimplePageComment.

      However, there is a problem in the code for the "lessonbuilder.read" events. These events can refer to either a SimplePage or a SimplePageItem, however the code always builds the event ref with the "/page/" identifier.

      Due to the way IDs are used in Lessons, it becomes impossible to determine if this event refers to a SimplePage or a SimplePageItem, because the IDs for both are just incrementing integers. So you could very well have both a SimplePage and a SimplePageItem with the same ID.

      There is code already in Lessons to determine the correct object the event refers to, but when building the event ref it always just sticks the "/page/" part in there regardless. This is a bug. It should be using the "/page/" OR "/item/" part depending on what object is being operated on. The solution is very simple, it's just two lines.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  bjones86 Brian Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code