Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38115

Regression : Save/Cancel on text link resource broken in current 1.4.x @ 107832

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.9.0
    • Fix Version/s: None
    • Component/s: Lessons
    • Labels:
      None
    • Previous Issue Keys:
      LSNBLDR-71

      Description

      Another regression from the basic lti change @ 107525 related to LSNBLDR-69.

      When the closePageProducer was added to the requestContext this breaks the buttons on the text page.
      https://source.sakaiproject.org/viewsvn/lessonbuilder/branches/lessonbuilder-1.4.x/tool/src/webapp/WEB-INF/requestContext.xml?r1=107525&r2=107524&pathrev=107525

      To reproduce (pretty easily)
      Click Add Text
      Click Save Or Cancel
      You get a blank page (no refresh)

      The Javascript errors appear in the console:
      Uncaught TypeError: Object [object Window] has no method 'hidepicker' ClosePage:13
      Uncaught ReferenceError: setMainFrameHeight is not defined ClosePage:8

      In the b05 release before this patch the Network requests get a 302 on ClosePage and a 200 on ShowPage.
      In the current 1.4.x, it gets 200 on ClosePage and never runs ShowPage. If I remove this bean then it works again, but this obviously isn't the correct but for an ASAP fix this feels like it will do.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  hedrick Charles Hedrick
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration