Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38122

Release to group setting for assignments not saved when using Assignments2

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0
    • Component/s: Lessons
    • Previous Issue Keys:
      LSNBLDR-175

      Description

      Lessons has the ability to release assignments, quizzes, etc, to selected groups. Even if an assignment or quiz is created with the option to release to the entire course, once the group setting is set in Lessons, it is applied to the assignment/quiz in question.
      Currently, group settings set through Lessons for Assignments are not being kept. Initially this did work on regression, and I'm not sure when this broke.
      To reproduce you will need a site with groups:
      Create an Assignment and leave the default to display to all
      Add the assignment into Lessons
      Click Edit in Lessons beside the assignment
      Click on "Edit the groups for which this item should be shown"
      Select a group and Update
      After the update, there is no [group] text beside the assignment
      Click Edit again and "Edit the groups for which this item should be shown"
      Settings were not saved

      Using breakpoints to step through what happens when you select a group and click update, I have tracked down a problem area to the Asssignments2Entity.java file, around line 582, the setGroups method.

      quick reference:
      https://gist.github.com/4268656

      Looking at this file, compared to the code used when you are using Assignments1, there is a big difference:
      https://gist.github.com/4268703

      There is hard coded sql in the Assignments2Entity, and for whatever reason, it never actually saves the groups, even when I verify that neither fgroups nor fassignGroups are null or empty.

      Additionally, my IDE gives me warnings in that area of code:

      -SQLService type is deprecated
      -transact method is deprecated
      -dbWrite method is deprecated

      At this point, I've kind of reached the limit of my knowledge and would like you to take a look to see if this can be changed somehow.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                hedrick Charles Hedrick
                Reporter:
                davpoind David R Poindexter (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code