Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38495

SiteService.getSiteSkin returns null instead of skin.default if no skin is set for a site

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.x
    • Fix Version/s: 10.0
    • Component/s: Kernel
    • Labels:
    • Previous Issue Keys:
      KNL-960

      Description

      When setSiteSkin is called it returns null if a skin has not been explicitly set on a site. Is this the expected behaviour? Shouldn't it return the name of the default skin as set by the skin.default property? Shouldn't it also prefix the skin with 'neo-' if 'portal.templates=neoskin' is set?

      The reason I'm asking is that I've always depended on getSiteSkin returning the actual skin name that is in use; now I've stopped explicitly specifying skins on sites, tools like YAFT, CLOG and ROSTER2 don't get styled. It seems odd having to implement logic in a tool to massage the skin appropriately when it could happen in getSiteSkin. SiteStats also implements some logic to sort the skin name out.

      I've attached a patch which mods BaseSiteService in the way I describe.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  a.fish@lancaster.ac.uk Adrian Fish
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration