Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38594

circular dependency between old memory service, ETS, UDS causes NPE on startup

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 10.0
    • Fix Version/s: 10.0, 11.0
    • Component/s: Kernel
    • Labels:
      None
    • 10 status:
      Resolved
    • Previous Issue Keys:
      KNL-1243

      Description

      NOTE: this was sorta caused by a combination of these tickets:
      KNL-1162 JSR-107 compatible memory service
      KNL-1027 Eliminate the use of covers in kernel services

      Using the NEW memory service has no issue but using the legacy (old) one causes a failure.
      So memory.use.legacy=true must be true in Sakai 10
      This does not affect Sakai 2.9 (or older) or Sakai 11 (or newer)

      The fix for this is make the use of UDS in the kernel/kernel-impl/src/main/java/org/sakaiproject/entity/impl/ReferenceComponent.java lazy (instead of requiring it on init)

      The origin of the issue is actually this line which uses the event handling service for logging a server start (according to the related jira: KNL_73):
      this.post(this.newEvent("server.start", serverConfigurationService().getString("version.sakai", "unknown") + "/" + serverConfigurationService().getString("version.service", "unknown"), false));

      I would also propose we simply convert this to an info log to avoid future issues. Nothing uses this event (and nothing could since the event is posted in the startup of the event service).

      Example:
      String sakaiVersion = serverConfigurationService().getString("version.sakai", "unknown") + "/" + serverConfigurationService().getString("version.service", "unknown");
      M_log.info("Server Start: serverId="serverConfigurationService().getServerId()",serverInstance="serverConfigurationService().getServerInstance()",serverIdInstance="serverConfigurationService().getServerIdInstance()",version="+sakaiVersion);

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  aaronz Aaron Zeckoski (Inactive)
                  Reporter:
                  aaronz Aaron Zeckoski (Inactive)
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration