Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38688

LRS code throws exception when using extra credit

    XMLWordPrintable

    Details

    • 10 status:
      Resolved
    • Previous Issue Keys:
      SAK-27967, KNL-1299

      Description

      Test plan:

      1.- As instructor add an assignment with Grade Scale "Points" and max 10.
      2.- Enter as student send the asignment.
      3.- As instructor grade the student with 20 (you have to confirm to set a value higher than max).
      4.- Now go to grade and click on "Release grades".

      In the log file you'll see this error:

      Caused by: java.lang.IllegalArgumentException: score raw (20.0) must not be greater than max (10.0) inclusive
      at org.sakaiproject.event.api.LearningResourceStoreService$LRS_Result.setRawScore(LearningResourceStoreService.java:852)
      at org.sakaiproject.event.api.LearningResourceStoreService$LRS_Result.setScore(LearningResourceStoreService.java:880)
      at org.sakaiproject.event.api.LearningResourceStoreService$LRS_Result.<init>(LearningResourceStoreService.java:809)
      at org.sakaiproject.assignment.impl.BaseAssignmentService.getLRS_Result(BaseAssignmentService.java:14151)
      at org.sakaiproject.assignment.impl.BaseAssignmentService.getStatementForAssignmentGraded(BaseAssignmentService.java:14143)
      at org.sakaiproject.assignment.impl.BaseAssignmentService.commitEdit(BaseAssignmentService.java:2471)
      at org.sakaiproject.assignment.cover.AssignmentService.commitEdit(AssignmentService.java:419)
      at org.sakaiproject.assignment.tool.AssignmentAction.doRelease_grades(AssignmentAction.java:9968)
      at org.sakaiproject.assignment.tool.AssignmentAction.doView_submission_list_option(AssignmentAction.java:4841)

      The problem is that LRS is checking that the grade is between min and max but assignments lets you grade with a value outside of the range.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ottenhoff Sam Ottenhoff
                  Reporter:
                  jjmerono@um.es Juan José Meroño Sánchez
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code