Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38693

error in modifying site can leave the site damaged or missing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Won't Fix
    • Affects Version/s: 2.7.x
    • Fix Version/s: None
    • Component/s: Kernel
    • Previous Issue Keys:
      KNL-797

      Description

      See BLTI-109 for a way to reproduce this. Ithaca has reported what looks like the same problem with Lesson Builder.

      I believe the problem is in the way sites are modified. The code in DbSiteService.saveTx deletes the whole site and puts it back.The assumptions that if anything goes wrong, the transaction won't be committed. But depending upon the version of Sakai and Mysql, and the settings of parameters, the pool management code may end up doing a commit when recycling a connection. I believe the whole transaction should be wrapped in a try and explicitly cancelled if it is not committed.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  k1team KERNEL TEAM (Inactive)
                  Reporter:
                  hedrick Charles Hedrick
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration