Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38855

Popup links from CKEditor get rewritten to target="_blank"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Critical
    • Resolution: Incorporated
    • Affects Version/s: 2.8.x, 2.9.x
    • Fix Version/s: None
    • Component/s: Kernel
    • Labels:
      None
    • Previous Issue Keys:
      KNL-1001

      Description

      CKEditor has the option to open links in a popup window and it does so by setting an onclick handler on the anchor tag. FormattedTextImpl.processAnchor strips off the onclick attribute and then uses its default target of "_blank". The included patch makes popups work by allowing anchor tags to have an onclick attribute as long as the code in the handler conforms to the form of "window.open(this.href, 'name', 'attributes'); return false;"

        Gliffy Diagrams

          Attachments

          1. onclick.patch.txt
            4 kB
            James Cook
          2. onclick.patch.txt
            4 kB
            James Cook

            Issue Links

              Activity

                People

                • Assignee:
                  aaronz Aaron Zeckoski (Inactive)
                  Reporter:
                  jamesc James Cook (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code