Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-39184

ClusterEventTracking is leaking database connections

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.4, 12.0, 19.0
    • Fix Version/s: 12.0, 19.0
    • Component/s: Kernel
    • Labels:
    • 12 status:
      Resolved
    • 11 status:
      Please Merge
    • 10 status:
      Please Merge
    • Previous Issue Keys:
      KNL-1547
    • Test Plan:
      Hide

      Basic regression test. Are events still being logged in the database SAKAI_EVENT? Any errors in logs?

      Show
      Basic regression test. Are events still being logged in the database SAKAI_EVENT? Any errors in logs?

      Description

      There is a leak of db connections from the pool in the ClusterEventTracking.

      It is visible in the logs if you have memory cluster enabled with event caching and enable the leak detection, like

      memory.cluster.names.count=4
      memory.cluster.names.1=org.sakaiproject.tool.impl.RebuildBreakdownService.cache
      memory.cluster.names.2=org.sakaiproject.authz.impl.DbAuthzGroupService.realmRoleGroupCache
      memory.cluster.names.3=org.sakaiproject.event.impl.ClusterEventTracking.eventsCache
      memory.cluster.names.4=org.sakaiproject.event.impl.ClusterEventTracking.eventLastCache
      
      leakDetectionThreshold@javax.sql.BaseDataSource=10000

      I will create a simple pull request to fix the leak.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ncaidin Neal Caidin
                  Reporter:
                  jonas.eriksson Jonas Eriksson (inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code