Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-39628

Upgrade kernel/master junit to 4.11

    XMLWordPrintable

    Details

    • Type: Task
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.0
    • Fix Version/s: 10.0
    • Component/s: Kernel
    • Labels:

      Description

      This was discussed on the sakai-dev list and Steve gave it support. I did a full build of trunk with no issues.

      JUnit 4.11 is the latest version released.

      It brings a pretty big improvement with JVM 7; more reliable tests and a predictable method orders. There are 3 options
      DEFAULT - Deterministic order based on an internal comparator but not predictable. (At least this means if it passes once, future failures aren't because of the order, unless some new test is added?)
      JVM - Order may vary from run to run
      NAME_ASCENDING - Based on method alphabetic names

      "Of course, well-written test code would not assume any order, but some does, and a predictable failure is better than a random failure on certain platforms."

      https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.11.md"

      In kernel, junit is currently 4.8.2, in master junit is 3.8.1. Seems like these could both be upgraded. It fixed a "seemingly random" test problem I was seeing recently. I did this locally and they built without problems (though that was expected) and the tool (dashboard) I was having random failures with has been building reliably with this version upgraded locally, was about 50% failure before.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                jonespm Matthew Jones
                Reporter:
                jonespm Matthew Jones
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code