Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-39761

ToolListener should only register files with .xml extension

    XMLWordPrintable

    Details

    • Type: Task
    • Status: CLOSED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.6.x, 2.7.x
    • Component/s: Kernel
    • Labels:

      Description

      When ToolListener goes into the webapp to look for tools to load, it will read from any filename. It should, for consistency, read only from files that end with .xml. The 'register' function of the ActiveToolManager that accepts a File as a parameter does this check but the ToolListener passes this resource as an unverified stream. This recently came up as an issue for us because 'patch' created a some files with an .orig extension which was loaded by sakai instead of the correct .xml registration file.

      The patch changes ToolListener to pass the tool path as a File rather than as a stream so it's checked.

      Also affects 2.5 versions of sakai.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                dhorwitz David Horwitz
                Reporter:
                jonespm Matthew Jones
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code