Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-39768

RequestFilter should catch some types of failures

    XMLWordPrintable

    Details

    • Type: Task
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.x
    • Fix Version/s: 2.6.x, 2.7.x
    • Component/s: Kernel
    • Labels:
      None

      Description

      When an NPE occurs in some types of requests, e.g. a podcasts RSS feed like

      /podcasts/site/ed3723db-e3dc-4701-b53c-8d01fa54957d

      the RequestFilter does not catch it. The client gets a blank document in response with an http 200 response code (OK).

      At the least, the RequestFilter should change the http response code to a 500 (internal server error), and maybe generate an emailed bug report.

      2008-12-18 14:26:41,083 WARN TP-Processor2 org.sakaiproject.util.RequestFilter -
      java.lang.NullPointerException
      at java.text.MessageFormat.applyPattern(MessageFormat.java:414)
      at java.text.MessageFormat.<init>(MessageFormat.java:350)
      at org.sakaiproject.component.app.podcasts.BasicPodfeedService.getPodfeedCopyright(BasicPodfeedService.java:372)
      at org.sakaiproject.component.app.podcasts.BasicPodfeedService.generatePodcastRSS(BasicPodfeedService.java:538)
      at org.sakaiproject.tool.podcasts.RSSPodfeedServlet.doGet(RSSPodfeedServlet.java:159)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:627)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
      at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:556)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
      at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:607)

        Gliffy Diagrams

          Zeplin

            Attachments

            1. KNL-93.patch
              0.8 kB
              Matthew Buckett

              Activity

                People

                Assignee:
                smarquard Stephen Marquard
                Reporter:
                smarquard Stephen Marquard
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration