Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-39779

Improve default log4j.properties

    XMLWordPrintable

    Details

    • Type: Task
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.x
    • Fix Version/s: 2.6.x, 2.7.x
    • Component/s: Kernel
    • Labels:
      None

      Description

      To enable better performance profiling (and for general usefulness), we should log the thread name in the log4j output, as such:

      kernel/kernel-common/src/main/config/log4j.properties:

      log4j.appender.Sakai.layout.ConversionPattern=%d

      {ABSOLUTE}

      %t %5p %F:%L %c

      {1}

      :%L - %m%n

      However, this pattern should be generally reviewed, e.g. to include a proper date format (with yyyy-mm-dd as well as time), and also in light of:

      http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html

      which warns that including the caller info and location (%F %L) is slow and potentially a performance issue, viz.

      "WARNING Generating caller location information is extremely slow. It's use should be avoided unless execution speed is not an issue."

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  ianeboston Ian Boston
                  Reporter:
                  smarquard Stephen Marquard
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration