Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40028

Duplicated assignments always have "Access: Display to Site" even if the original had groups

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 11.5 [Tentative], 12.2, 19.0
    • Fix Version/s: 12.3, 19.0
    • Component/s: Assignments
    • Labels:
    • 12 status:
      Resolved
    • Test Plan:
      Hide

      -Create a section/group with a few students.

      -Create a new assignment and configure it with "Access: Display only to selected groups" and click on the previous group.

      -Select "Group submission - One submission per group"

      -Post the assignment.

      -Duplicate the assignment and edit the draft created.

      -Access: Display to site is selected.

      -In master, trying to post the assignment throws an alert because group submission needs some group selected.

      -In 11.x the alert is not thrown and it allows to post the assignment, causing some nasty issues (students cant see submissions, ghost rows in database...)

      Show
      -Create a section/group with a few students. -Create a new assignment and configure it with "Access: Display only to selected groups" and click on the previous group. -Select "Group submission - One submission per group" -Post the assignment. -Duplicate the assignment and edit the draft created. -Access: Display to site is selected. -In master, trying to post the assignment throws an alert because group submission needs some group selected. -In 11.x the alert is not thrown and it allows to post the assignment, causing some nasty issues (students cant see submissions, ghost rows in database...)

      Description

      When duplicating an assignment, the created draft assignment doesn't have the same groups that the original assignment has. In fact, "Display to site" is always configured by default in Access section.

      It's not a big deal in master because when clicking on "Post" the assignment throws an alert that forces to the user to choose groups if they are needed (i.e. Group Submission). But in 11.x this alert doesn't exist and user is able to post the assignment with a forbidden configuration. This has caused us some trouble.

      My proposed patch is to create the duplicated assignment with the same groups that the source assignment.

        Gliffy Diagrams

          Attachments

            Issue Links

            is depended on by

            Bug - A problem which impairs or prevents functionality of the product. SAK-33995 Roll-Up Jira for Import from Site, Duplicate and CourseSite creation from template

            • Major - Major loss of function or need for functionality in production in the near future.
            • OPEN
            relates to

            Bug - A problem which impairs or prevents functionality of the product. SAK-40639 Duplicating a site copies the groups locked by Assignments with the lock pointing to the old assignment

            • Blocker - Blocks development and/or testing work, production could not run without this feature working correctly.
            • CLOSED

            Bug - A problem which impairs or prevents functionality of the product. SAK-40148 Conversion job for group assignments with access type SITE

            • Major - Major loss of function or need for functionality in production in the near future.
            • CLOSED

              Activity

                People

                • Assignee:
                  ern Earle R Nietzel
                  Reporter:
                  daniel.merino Daniel Merino Echeverría
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code