Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40098

site-manage > SWITCH changes for table toolbar controls

    XMLWordPrintable

    Details

    • Test Plan:
      Hide

      Test all aspects of:

      1. Site Info
      2. Membership
      3. Worksite Setup
      4. Site Browser
      Show
      Test all aspects of: Site Info Membership Worksite Setup Site Browser

      Description

      The linked PR will follow in the footsteps of SAK-40248, by applying the new standardized paging, filter, and menu components to the various interfaces in site-manage. The following list enumerates the changes proposed in the linked PR:

      • SWITCH generic changes:
        • mirror table controls on top and bottom of table (pager, view, search, buttons)
          • bottom controls displayed only if list.size > 10 && pageSize > 10
          • applied to "Worksite Setup", "Site Browser", "Membership", and "Manage Participants"
        • if no search results:
          • table controls are still present, but disabled
          • no results message moved into the table
        • standardize button text on tab pages of "Site Info" (cancel goes to landing page, back goes to previous page in train/wizard)
        • make all sub projects of "Site Info" return to landing page on click "Cancel" rather than previously selected tab
          • exceptions being "External Tools" and "User Audit Log"
          • these don't live in site-manage
          • also don't have a "Cancel" button
          • only way to leave these UIs is to use tool reset, which takes you to landing page anyway
        • extend use of toolbar, paging, search and view Velocity macros to "Membership", "Site Browser", "Worksite Setup", and "Manage Participants"
        • extend use of MenuBuilder pattern to "Site Browser", "Site Info", "Worksite Setup", and "Membership"; exceptions being:
          • "Tool Order" - sub RSF project
          • "Add Participants" - sub RSF project
          • "Manage Groups" - sub RSF project
          • "Link to Parent Site" - sub Velocity project
          • "External Tools" - separate project (sakai.basiclti.admin.helper)
          • "User Audit Log" - separate project (sakai.useraudit)
        • remove duplicated pager messages and other unused/removed messages in bundles of site-manage
      • "Site Info" landing page changes:
        • add tab for "Manage Participants"
        • add tab for landing page ("Site Information")
        • make "Add Participants" beside "Manage Participants" in menu
        • removed participants list (moved to new "Manage Participants" tab)
        • removed redundant header
      • "Edit Site Information" changes:
        • removed redundant header
        • removed unnecessary messages for same UI in "Worksite Setup"
        • conditionally render required star for site title (don't need star if site title not editable)
        • conditionally render skin drop-down and label (if no skins to pick from, don't display the field)
      • "Manage Tools" changes":
        • remove redundant header for "Site Info" context; genericize for "Worksite Setup" context
        • remove needless info message "Choose tools to include..."
        • make the "General" tools accordion section collapsible
      • "Add Participants" changes:
        • after successfully adding users, always return to "Manage Participants" (regardless of whatever the previously selected tab was)
      • "Manage Participants" changes:
        • add buttons to top of form
        • applied spinners to "Search" and "Clear" buttons
        • implement filter by all, section, role, group
        • removed redundant heading
        • make "ID" column non-conditionally rendered
        • populate "ID" column with displayId rather than regId
        • don't concatenate name and ID in "Name" column
        • move "Search" out of "Name" column header
        • put "no participants matching filter" message below table headers
        • removed allowedRoles restrictions on "Role Descriptions" panel
        • removed all in-line styles
        • clicking "Cancel" removes any search/filter, and takes you back to landing page (does not remove page #, page size)
        • put "last updated" string at top of page, above print view link (match style in statistics)
      • "Edit Class Roster(s)" changes:
        • old tab for "Add Roster(s)" removed; made into a link above roster table
        • removed redundant header
      • "Manage Access" changes:
        • remove redundant header for "Site Info" context; genericize for "Worksite Setup" context
        • removed needless info message "Set site access..."
      • "Duplicate Site", "Import from Site, and "Import from Archive File" changes:
        • removed redundant headers
      • "Membership" changes:
        • remove redundant headers
        • fix table structures and styling
        • conditionally render checkbox column in table for "My Current Sites"
        • created "Action" column in "Joinable Sites" (matches table style in "Site Browser")
        • fixed bug in dual-logic (term start, then alphabetical) bucket sorting for "My Official Course Enrolments" sorting on "Term" column
      • "Site Browser" changes:
        • redesign search form; removed unnecessary user facing messages
        • fix table structures and styling on list page
        • remove tab on list page; change to link in search results text container
        • remove redundant header on list page
        • provide "Back to Search" link when search returns no results
      • "Worksite Setup" changes:
        • removed unnecessary user facing messages (don't need to explain how to use checkboxes and buttons)
        • fixed bug where if no search results returned, two info messages appear with virtually the same text
        • fixed bug when search returns results, message would say 'in the view of site_type_all', etc.
        • improved both messages to surround search text and view type in double quotes
        • changed "New" tab to "Create New Site" to match the button in the sites panel (portal top bar)
        • main list should only ever have three buttons (Edit, Delete, Hard Delete)
        • softly deleted list should only ever have two buttons (Delete, Restore)
        • change text of buttons to "<__> Selected"
        • add current tab for "Site List"

      Original ticket description:

      It was mentioned at the conference in mega sites that Site Manage first page can be slow in large classes. I profiled it and saw that it basically just calls "getParcipantList" and seems like it only uses this for a count to put the size in the context

          context.put("participantListSize", Integer.valueOf(participantsCollection.size()));
      

      I'd think there's probably a better way to do this than what this is calling if this was investigated.

      Brian Jones mentioned they redesigned Site Manage to move this page to an entirely new tab. This could be a good idea but it's probably good to also get this fixed.

        Gliffy Diagrams

          Zeplin

            Attachments

            1. 1a-siteBrowser_search-before.png
              1a-siteBrowser_search-before.png
              27 kB
            2. 1b-siteBrowser_search-after.png
              1b-siteBrowser_search-after.png
              18 kB
            3. 1c-siteBrowser_list-before.png
              1c-siteBrowser_list-before.png
              88 kB
            4. 1d-siteBrowser_list-after.png
              1d-siteBrowser_list-after.png
              92 kB
            5. 1e-siteBrowser_list_noResults-before.png
              1e-siteBrowser_list_noResults-before.png
              11 kB
            6. 1f-siteBrowser_list_noResults-after.png
              1f-siteBrowser_list_noResults-after.png
              18 kB
            7. 2a-membership_currentSites_noCheckbox-before.png
              2a-membership_currentSites_noCheckbox-before.png
              41 kB
            8. 2b-membership_currentSites_noCheckbox-after.png
              2b-membership_currentSites_noCheckbox-after.png
              37 kB
            9. 2c-membership_currentSites_withCheckbox-before.png
              2c-membership_currentSites_withCheckbox-before.png
              46 kB
            10. 2d-membership_currentSites_withCheckbox-after.png
              2d-membership_currentSites_withCheckbox-after.png
              50 kB
            11. 2e-membership_currentSites_noResults-before.png
              2e-membership_currentSites_noResults-before.png
              17 kB
            12. 2f-membership_currentSites_noResults-after.png
              2f-membership_currentSites_noResults-after.png
              25 kB
            13. 2g-membership_enrolments-before.png
              2g-membership_enrolments-before.png
              42 kB
            14. 2h-membership_enrolments-after.png
              2h-membership_enrolments-after.png
              38 kB
            15. 2i-membership_enrolments_noResults-before.png
              2i-membership_enrolments_noResults-before.png
              23 kB
            16. 2j-membership_enrolments_noResults-after.png
              2j-membership_enrolments_noResults-after.png
              32 kB
            17. 2k-membership_enrolments_noEnrolments-before.png
              2k-membership_enrolments_noEnrolments-before.png
              20 kB
            18. 2l-membership_enrolments_noEnrolments-after.png
              2l-membership_enrolments_noEnrolments-after.png
              29 kB
            19. 2m-membership_joinable-before.png
              2m-membership_joinable-before.png
              26 kB
            20. 2n-membership_joinable-after.png
              2n-membership_joinable-after.png
              21 kB
            21. 2o-membership_joinable_noResults-before.png
              2o-membership_joinable_noResults-before.png
              17 kB
            22. 2p-membership_joinable_noResults-after.png
              2p-membership_joinable_noResults-after.png
              19 kB
            23. 3a-worksiteSetup-before.png
              3a-worksiteSetup-before.png
              67 kB
            24. 3b-worksiteSetup-after.png
              3b-worksiteSetup-after.png
              116 kB
            25. 3c-worksiteSetup_noResults-before.png
              3c-worksiteSetup_noResults-before.png
              18 kB
            26. 3d-worksiteSetup_noResults-after.png
              3d-worksiteSetup_noResults-after.png
              31 kB
            27. 4a-siteInfo_landingPage-before.png
              4a-siteInfo_landingPage-before.png
              97 kB
            28. 4b-siteInfo_landingPage-after.png
              4b-siteInfo_landingPage-after.png
              61 kB
            29. 4c-siteInfo_editSiteInfo-before.png
              4c-siteInfo_editSiteInfo-before.png
              63 kB
            30. 4d-siteInfo_editSiteInfo-after.png
              4d-siteInfo_editSiteInfo-after.png
              63 kB
            31. 4e-siteInfo_manageTools-before.png
              4e-siteInfo_manageTools-before.png
              96 kB
            32. 4f-siteInfo_manageTools-after.png
              4f-siteInfo_manageTools-after.png
              102 kB
            33. 4g-siteInfo_editClassRoster-before.png
              4g-siteInfo_editClassRoster-before.png
              18 kB
            34. 4h-siteInfo_editClassRosters-after.png
              4h-siteInfo_editClassRosters-after.png
              22 kB
            35. 4i-siteInfo_manageAccess-before.png
              4i-siteInfo_manageAccess-before.png
              62 kB
            36. 4j-siteInfo_manageAccess-after.png
              4j-siteInfo_manageAccess-after.png
              65 kB
            37. 4k-siteInfo_dupSite-before.png
              4k-siteInfo_dupSite-before.png
              24 kB
            38. 4l-siteInfo_dupSite-after.png
              4l-siteInfo_dupSite-after.png
              28 kB
            39. 4m-siteInfo_importFromSite-before.png
              4m-siteInfo_importFromSite-before.png
              25 kB
            40. 4n-siteInfo_importFromSite-after.png
              4n-siteInfo_importFromSite-after.png
              33 kB
            41. 4o-siteInfo_importFromArchive-before.png
              4o-siteInfo_importFromArchive-before.png
              15 kB
            42. 4p-siteInfo_importFromArchive-after.png
              4p-siteInfo_importFromArchive-after.png
              21 kB
            43. 4q-siteInfo_manageParticipants-before.png
              4q-siteInfo_manageParticipants-before.png
              71 kB
            44. 4r-siteInfo_manageParticipants-after.png
              4r-siteInfo_manageParticipants-after.png
              115 kB
            45. 4s-siteInfo_manageParticipants_noResults-before.png
              4s-siteInfo_manageParticipants_noResults-before.png
              80 kB
            46. 4t-siteInfo_manageParticipants_noResults-after.png
              4t-siteInfo_manageParticipants_noResults-after.png
              51 kB
            47. image-2018-06-06-16-55-06-089.png
              image-2018-06-06-16-55-06-089.png
              85 kB
            48. image-2019-02-22-16-34-53-423.png
              image-2019-02-22-16-34-53-423.png
              35 kB
            49. image-2019-02-22-16-35-16-656.png
              image-2019-02-22-16-35-16-656.png
              19 kB
            50. NewControl.png
              NewControl.png
              16 kB
            51. TemporaryOpeningPage.png
              TemporaryOpeningPage.png
              10 kB

              Issue Links

                Activity

                  People

                  Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration