Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40261

Textarea > obey Resources tool visibility in elFinder

    Details

    • Type: Feature Request
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 11.5 [Tentative], 12.2, 19.0
    • Fix Version/s: None
    • Component/s: elFinder
    • Labels:
      None
    • 12 status:
      Please Merge
    • Test Plan:
      Hide
      1. In any site, add the Resources tool and any tool which student users can access a CKEditor (Assignments, Forums, Tests & Quizzes, etc.)
      2. As instructor, upload several files to the Resources tool
      3. As instructor, set only one of the previously uploaded files to 'Hide this item'
      4. As student, go to the site and access a CKEditor
      5. Click the link icon, then 'Browse Server'
      6. Verify you can link to the files in the Resources tool, but the specific file you hid is not available as a choice
      7. As instructor, hide the Resources tool from students (Site Info > Tool Order > Make Tool Invisible to Students)
      8. As student, go back to the site and access a CKEditor
      9. Verify you cannot link to any file in Resources
      Show
      In any site, add the Resources tool and any tool which student users can access a CKEditor (Assignments, Forums, Tests & Quizzes, etc.) As instructor, upload several files to the Resources tool As instructor, set only one of the previously uploaded files to 'Hide this item' As student, go to the site and access a CKEditor Click the link icon, then 'Browse Server' Verify you can link to the files in the Resources tool, but the specific file you hid is not available as a choice As instructor, hide the Resources tool from students (Site Info > Tool Order > Make Tool Invisible to Students) As student, go back to the site and access a CKEditor Verify you cannot link to any file in Resources

      Description

      Currently, if you hide an uploaded file or folder in the Resources tool, that file/folder will not appear for students when using the 'Browse Server' method to link to files on the server.

      However, if you hide the Resources tool in entirety (Site Info > Tool Order > Make Tool Invisible to Students), all files and folders which are not explicitly hidden themselves will still be accessible to students via the 'Browse Server' method. This is counter intuitive, as the the typical use case for hiding the Resources tool from students is so that they cannot access the files and folders within, without the need to go into each file and folder individually and set them to be hidden.

      The linked PR alters the textarea code to check if the Resources tool is hidden. If so, it will not return any file or folder entries; otherwise it returns any that are not individually hidden (original behaviour).

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  bjones86 Brian Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration