Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40286

Library: Update SASS mixins to fix minor styling and usage issues

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 12.2, 19.0
    • Fix Version/s: 19.0
    • Component/s: Library
    • Labels:
      None
    • Test Plan:
      Hide

      General testing around Sakai to make sure things align in webkit and non-webkit browsers

      Show
      General testing around Sakai to make sure things align in webkit and non-webkit browsers

      Description

      In our SASS files in the Library project, Sakai has a _compass.scss file containing a number of SASS mixins for short-handing CSS properties, particularly browser prefixes.

      There are a few issues with some of these mixins:

      • vendor prefixes should appear first, so they can be overridden by non-prefixed styles
      • the justify-content mixin contains an include for display-flex, while none of the other flex-related mixins have an include (this either causes duplication in the output or improper usage)
      • the display-flex mixin requires a parameter to be passed in, but it is not used for the webkit-prefixed style inside the rule

      Fix these issues to improve the output and usage of these mixins.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                sfoster9 Shawn Foster
                Reporter:
                sfoster9 Shawn Foster
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code