Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40294

Library: Remove magic number from SAK-40287

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 19.0
    • Fix Version/s: 19.0
    • Component/s: Library
    • Labels:
      None
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      When working on the fix for SAK-40287, I had to add a magic number of 1px to the height calculation because I couldn't find where the 1px was coming from. This bothered me. I have finally found it: it is coming from the height of the #Mrphs-viewport-helpers children.

      Remove the 1px height from these children and remove the magic number from my #toolMenuWrap calculation.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  sfoster9 Shawn Foster
                  Reporter:
                  sfoster9 Shawn Foster
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code