Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40469 Implement LTI 1.3 Core in Sakai
  3. SAK-40480

Fix identifiers on each of the fields in FOORM output to allow show/hide

    Details

    • Type: Sub-task
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 19.0
    • Component/s: None
    • Labels:
    • Test Plan:
      Hide

      This needs a general test of the functionality of Foorm screens - they are used in the Site Info -> External tools functionality.   Create LTI items, view them, and edit them.  Make sure data is flowing.  Make sure that data entered is not lost.  Make sure radio buttons and checkboxes can be turned on and off and the new value is what gets stored.  Another test is to go to a page with a Foorm form on it, view source, copy and paste it into the HMTL validator at:

      https://validator.w3.org/nu/

      There will be small errors perhaps in the portal (these should be fixed one day) - but none in the Foorm markup.

      Show
      This needs a general test of the functionality of Foorm screens - they are used in the Site Info -> External tools functionality.   Create LTI items, view them, and edit them.  Make sure data is flowing.  Make sure that data entered is not lost.  Make sure radio buttons and checkboxes can be turned on and off and the new value is what gets stored.  Another test is to go to a page with a Foorm form on it, view source, copy and paste it into the HMTL validator at: https://validator.w3.org/nu/ There will be small errors perhaps in the portal (these should be fixed one day) - but none in the Foorm markup.

      Description

      Foorm already has an id="custom.input" convention to allow portions of the UI to be dynamically hidden / shown using JavaScript on insert, edit, or view outputs.    Fix any that are implemented incorrectly like the h4's, ol's and textarea's.

      For example:

      <p id="custom.input" class="longtext" style="clear:all;"><p id="custom.input" class="foorm-textarea" style="clear:all;"><label for="custom" style="display:block;float:none;">Custom Parameters (key=value on separate lines)</label><textarea style="border:1px solid #555;width:300px" id="custom" name="custom" rows="5" cols="25"/></textarea></label></p>
      

      And also (2 errors below - both the h4 and the ol)  Note also the stray </label>

      <h4>Allow tool title to be changed</h4> <ol style="list-style-type:none"> <li style="border:padding:3px;;margin:7px 3px;"> <input type="radio" name="allowtitle" value="0" id="allowtitle_disallow" checked="checked"/> <label for="allowtitle_disallow">Do not allow</label></li> <li style="border:padding:3px;;margin:7px 3px;"> <input type="radio" name="allowtitle" value="1" id="allowtitle_allow"/> <label for="allowtitle_allow">Allow</label></li> </ol> </label>
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code