Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40485

Clean up wiki read events

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 12.3
    • Fix Version/s: 19.0
    • Component/s: Rwiki
    • Labels:
      None
    • Test Plan:
      Hide
      • Make sure SiteStats and Wiki are added to the site and SiteStats is showing wiki read events
      • Go to the wiki home page, and add comments to it
      • Check the read event count for wiki in sitestats
      • Return to the wiki home page, do not visit other wiki pages
      • Return to sitestats and confirm the count has only increased by 1
      Show
      Make sure SiteStats and Wiki are added to the site and SiteStats is showing wiki read events Go to the wiki home page, and add comments to it Check the read event count for wiki in sitestats Return to the wiki home page, do not visit other wiki pages Return to sitestats and confirm the count has only increased by 1

      Description

      --SAK-23566-- added read events for the wiki, but there appear to be several problems with the way it was done:

      • clicking the Edit tab fires a read event when it should not (this was indicated in code comments as a known issue)
      • If the page has any comments, a separate read event is fired for each comment, which is unnecessary since the comments are not being viewed in isolation but rather automatically as part of rendering the parent page
      • the event references from -SAK-23566- do not match the pattern used by the other event code in the tool

      It turns out also that read events were already tracked by the wiki, just disabled by default. As of Sakai 12 (see SAK-21039), it is enabled by default, so we now have duplication of read events.

      At this point, I think the code introduced in SAK-23566 can just be removed.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  plukasew Paul Lukasewych
                  Reporter:
                  plukasew Paul Lukasewych
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code