Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40591 GradebookNG performance rollup issues
  3. SAK-40603

Rewriting the grade table on every grade save is probably too intensive

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Verified
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 12.4, 19.0
    • Component/s: None
    • Labels:
      None
    • Test Plan:
      Hide

      Basic regression test:

      1) Create a course with Gradebook
      2) Create a few Gradebook items
      3) Place GB items into categories
      4) Enter grades for students.

      Show
      Basic regression test: 1) Create a course with Gradebook 2) Create a few Gradebook items 3) Place GB items into categories 4) Enter grades for students.
    • 12 status:
      Resolved

      Description

      Using the steps to replicate in parent issue (120 items in categories with drop lowest), you observe slowness after modifying a student grade. For example, changing one grade item could cause new Drop Lowest calculations and thus cause some cells to be re-styled.

      Maybe this is too intense to do on each gradebook item save? Instructors report frustration when their primary goal is entering a bunch of new grades quickly. New drop lowest calculations are not a priority when in data entry mode.

      The XHR for saving one modified student score is about 46 ms so I believe a large amount of the time is spent rewriting the HandsOnTable.

        Gliffy Diagrams

          Zeplin

            Attachments

            1. 12x-after-patch.png
              12x-after-patch.png
              1.14 MB
            2. 12x-before-patch.png
              12x-before-patch.png
              1.09 MB
            3. after-mark-patch.png
              after-mark-patch.png
              1.17 MB
            4. Screen Shot 2018-09-13 at 10.55.22 AM.png
              Screen Shot 2018-09-13 at 10.55.22 AM.png
              1.23 MB

              Activity

                People

                • Assignee:
                  jtingen Jolie Tingen
                  Reporter:
                  ottenhoff Sam Ottenhoff
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Integration