Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40803

Assignments reminder: The date format should follow the user preferences.

    Details

    • 19 status:
      Resolved
    • Test Plan:
      Hide
      1. Create a new assignment and set the due date to 1 day and 5 minutes after the moment you created it.
      2. Read the log files and look for the email, the reminder email should have the date in this format "MMM dd, yyyy 'at' hh:mm aa".
      3. Login as student (Same site, student of that site) and change your language to Spanish
      4. Login as instructor again and repeat 1 and 2, the date format of the email should be the same.As student, set your language to Spanish.
      5. After the fix, the email should be localised in terms of month names with an '@' instead of 'at'. So, in spanish, 'dic' instead of 'Dec'.
      Show
      Create a new assignment and set the due date to 1 day and 5 minutes after the moment you created it. Read the log files and look for the email, the reminder email should have the date in this format "MMM dd, yyyy 'at' hh:mm aa". Login as student (Same site, student of that site) and change your language to Spanish Login as instructor again and repeat 1 and 2, the date format of the email should be the same.As student, set your language to Spanish. After the fix, the email should be localised in terms of month names with an '@' instead of 'at'. So, in spanish, 'dic' instead of 'Dec'.

      Description

      SAK-40544 is an amazing feature but has some know I18N issues, the date format is hardcoded in the source, it should use the user preferences.

      https://github.com/sakaiproject/sakai/blob/master/assignment/impl/src/java/org/sakaiproject/assignment/impl/reminder/AssignmentDueReminderServiceImpl.java#L135

      SimpleDateFormat sdf = new SimpleDateFormat("MMM dd, yyyy 'at' hh:mm aa");
      Instant dueDate = assignment.getDueDate();
      String formattedDateDue = sdf.format(dueDate);

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  a.fish@lancaster.ac.uk Adrian Fish
                  Reporter:
                  farreri Miguel Pellicer
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code